[RADIATOR] OTP Authentication failed logging

[Hartmaier Alexander]

On 2016-06-23 17:04, Heikki Vatiainen wrote:
> On 16.06.2016 17:55, Hartmaier Alexander wrote:
>
>> I've encountered some 'OTP Authentication failed: ()' logs and digged
>> deeper where there coming from.
>> Line 104 returns if $result is undefined, line 107 if it's a true value
>> so the else tree is only hit if $reason is false in which case its value
>> is logged.
>> Is that's how you intended it?
> We took a look at this, and while the checks themselves look good, the
> log message is misleading. It looks like it is supposed to log an error
> or reason message. There might have been an error or reason message
> available earlier.
Will you change the log message?
>
> I'd say the best option is to log any failure reason in the OTP's
> VerifyHook if any special logs are needed.
We don't have a custom VerifyHook but use what comes with Radiator.
>
> Thanks for notifying us about this!
> Heikki
>



*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*
T-Systems Austria GesmbH Rennweg 97-99, 1030 Wien
Handelsgericht Wien, FN 79340b
*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*
Notice: This e-mail contains information that is confidential and may be privileged.
If you are not the intended recipient, please notify the sender and then
delete this e-mail immediately.
*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*