[RADIATOR] SqlDb Patch 1.39 breaks on AuthSQLTOTP and AuthSQLHOTP

[Mike McCauley]

Hello Steffen,

thanks for reporting this. There was indeed a problem with the initialisation 
of those modules, which we have fixed in the latest patch set.

We apologise for any inconvenience.

Cheers.

On Thursday 07 October 2010 09:50:20 pm Steffen Weinreich wrote:
> Hi!
>
> Today I have downloaded the latest patchset to play with  AuthSQLTOTP
> and AuthSQLHOTP and had some headaches because all SQL Query's in this
> modules  fails with
>
> Thu Oct  7 11:27:13 2010: DEBUG: Query is: 'select secret, counter_high,
> counter_low, active, pin, digits, bad_logins, unix_timestamp(accessed)
> from hotpkeys where username='mikem'':
> Thu Oct  7 11:27:13 2010: DEBUG: Radius::AuthSQLHOTP IGNORE: Database
> failure: mikem [mikem]
>
> After doing some debugging on this, I saw that in SqlDb.pm the variable
> $self->{SQLRetries} does not get initialized in the context of
> AuthSQLTOTP and AuthSQLHOTP. According to the diffs between the Release
> 4.7 and the patchset this variable has been added between 1.37 and 1.39
> of SqlDb.pm.
>
> I think there are some calls to the SqlDb.pm initalizing missing in (at
> least) AuthSQLTOTP and AuthSQLHOTP.
>
> cheerio
>    Steve
>
> --
> Stillstand ist nutzlos. Es gibt eines oder das andere,
> entweder Fortschritt oder Nachlassen. -- Lord Robert Baden-Powell



-- 
Mike McCauley                               mikem at open.com.au
Open System Consultants Pty. Ltd
9 Bulbul Place Currumbin Waters QLD 4223 Australia   http://www.open.com.au
Phone +61 7 5598-7474                       Fax   +61 7 5598-7070

Radiator: the most portable, flexible and configurable RADIUS server 
anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, 
Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, 
TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP,
DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.