(RADIATOR) Possible bug in Radiator 2.19 AuthLDAP2.pm

[Valentin Tumarkin]

 Hi,

$self->{bound} tells us if we are already connected

$self->{NoBindBeforeOp} tells us the we should not re-bind before
every operation (for performance reasons). NoBindBeforeOp actually
means 'NoBindBeforeEveryOp'.

So the whole statement reads: Do not continue, if we are already 'binded'
and should not re-bind before every operation.

If 'or' operator was used and NoBindBeforeOp = 1, then Radiator
would never bind/connect to LDAP server.


v
|
| Valentin Tumarkin
| Xpert Integrated Systems Ltd.
| E-Mail: tv at xpert.com
| Office: +972-9-9522380
| Mobile: +972-53-544887
+------------------------------------>

On Fri, 11 Jan 2002, Christophe Wolfhugel wrote:

> Good morning.
>
> The code contains :
>
> sub bind
> {
>     my ($self, $name, $password) = @_;
>
>     $self->log($main::LOG_INFO, "wolf bind bound=$self->{bound}");
>     return 1 if (   $self->{bound}
>                  && $self->{NoBindBeforeOp});
>
> Shouldn't the test use the "or" statement rather than "and", ie :
>
>     return 1 if (   $self->{bound}
>                  || $self->{NoBindBeforeOp});
>
> --
> Christophe Wolfhugel -+- wolf at oleane.net -+- France Telecom Transpac
> Direction des opérations, CSI Gennevilliers
> ===
> Archive at http://www.open.com.au/archives/radiator/
> Announcements on radiator-announce at open.com.au
> To unsubscribe, email 'majordomo at open.com.au' with
> 'unsubscribe radiator' in the body of the message.
>

===
Archive at http://www.open.com.au/archives/radiator/
Announcements on radiator-announce at open.com.au
To unsubscribe, email 'majordomo at open.com.au' with
'unsubscribe radiator' in the body of the message.