[RADIATOR] Multi-Line Handler issues with 4.10

[Michael]

yep, correct.  The multi-line config support was broken in 4.10 then partially fixed with then patch-set.


A couple points of interest for the fix though, that i have changed for myself.  This is my own personal opinion and may not be agreed with anyone else:

Ignoring commented lines in config should probably include leading white space so people can indent their comments if they want.
-       next if $line =~ /^#/;
+       next if $line =~ /^\s*#/;

Blank lines should be ignored, and should also include whitespace for blank lines that actually have spaces, or tabs on them because you can't see them.  best to just ignore.
-       next if $line eq '';
+       next if $line =~ /^\s*$/;



Also, the ($line eq '') will never equal a blank line because a blank line has a carriage return and line feed values on it that you don't actually see.  a blank line has an 0x0A and 0x0D hex characters i think at the end of the line.
So this line:
next if $line eq '';
wont work, but this line:
next if $line =~ m/^$/;
will.


The order of these i also changed.  Ignore blank and commented lines i would think should be first before anything.


On 12-08-13 11:30 AM, alan buxey wrote:
> Hi,
>
>> why i want to is besides the point.  Because, I don't actually want to really.  it's a matter of it already being done.   It must be within the standard specs of the parser i guess, since it's always worked before and the docs probably said you could do it.  But don't worry about it.  i patched it myself. I will maintain this patch for myself and for future versions.
>
> I seem to recall that there was a change which also broke
> multi-line configs (ie those with just the \ at the end...) which
> was then fixed as part of the patch-set.  Obviously this also
> affected the way your configuration was also read in.
>
> alan
>
>