[RADIATOR] incorrect doc in 5.7.2 GetClientQuery?

[Mike McCauley]

Hello Alexander,

Thanks for reporting this.

On Tuesday 07 September 2010 06:56:12 pm Alexander Hartmaier wrote:
> The 4.7 ref manual says on page 46:
>
> A comma-separated list of flag names as field 25
>
> But the code says:
>         $client->set('ClientHook', $self->file_substitution($row[25]))
>             if defined $row[25]; # Make sure it gets compiled
>
> and:
>
>         # Contributed by "Tony B" <tonyb at go-concepts.com>
>         # Last row can be a comma separated list of flag names
>         map $client->{$_}++, split(/,/, $row[25]);
>
> Is the 25th field the ClientHook or something else?
> Whatfor are those 'flags'?

There were 2 problems here: an error in the doc and an error in the code. The 
correct case is:

Field 25 is ClientHook 
Field 27 is flags

from the new doc:

A comma-separated list of flag names as field 27. Each comma separated name in 
the field will be used to set a Client flag type parameter. For example if 
field 27 has the 
value: "IgnoreAcctSignature,UseOldAscendPasswords,StatusServerShowClientDetails", 
it will set the IgnoreAcctSignature, UseOldAscendPasswords and 
StatusServerShowClientDetails flag parameters in the resulting Client.

The fixed code is in the latest patch set, and the fixed doc will appear in 
the next release.

Thanks again.
Cheers.


>
> --
> Alexander Hartmaier <alexander.hartmaier at t-systems.at>
> T-Systems Austria GesmbH
>
>
>
> *"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*
>"* T-Systems Austria GesmbH   Rennweg 97-99, 1030 Wien
> Handelsgericht Wien, FN 79340b
> *"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*
>"* Notice: This e-mail contains information that is confidential and may be
> privileged. If you are not the intended recipient, please notify the sender
> and then delete this e-mail immediately.
> *"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*"*
>"* _______________________________________________
> radiator mailing list
> radiator at open.com.au
> http://www.open.com.au/mailman/listinfo/radiator



-- 
Mike McCauley                               mikem at open.com.au
Open System Consultants Pty. Ltd
9 Bulbul Place Currumbin Waters QLD 4223 Australia   http://www.open.com.au
Phone +61 7 5598-7474                       Fax   +61 7 5598-7070

Radiator: the most portable, flexible and configurable RADIUS server 
anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, 
Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, 
TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP,
DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.